Re: [libvirt] [PATCH] cpu_conf: add comments about sockets in cpu_conf

On Tue, Oct 18, 2016 at 16:18:10 +0800, Chen Hanxiao wrote: > From: Chen Hanxiao <chenhanxiao(a)gmail.com&gt; > > 'sockets' in output of `virsh capabilities' means You are talking here about virsh capabilities, while the code is about the cpu definition in the domain configuration. > the sockets per NUMA node, > which is a special case. Indeed it is a special case in the capabilities XML. So why are you changing the code relevant to domain definition, where the sockets count is actually the total sockets count? > discuss in: > https://www.redhat.com/archives/libvir-list/2012-March/msg01123.html https://www.redhat.com/archives/libvir-list/2012-March/msg01133.html describes why sockets per NUMA node is not really what we want.