Re: [libvirt] [PATCH] qemu: Improve some qemu.conf error reporting
On 06/30/2010 02:38 PM, Cole Robinson wrote:
Log some info if we can't find a config file. Make parse
failures
fatal, and actually raise an error message.
Signed-off-by: Cole Robinson <crobinso(a)redhat.com>
ACK.
#define CHECK_TYPE(name,typ) if (p && p->type != (typ)) {
\
qemuReportError(VIR_ERR_INTERNAL_ERROR, \
- "remoteReadConfigFile: %s: %s: expected type " #typ,
\
- filename, (name)); \
+ "%s: %s: %s: expected type " #typ, \
+ __func__, filename, (name)); \
Hmm, this reminds me of my pending question of whether we should prefer
__func__ (C99, and guaranteed by gnulib) or __FUNCTION__ (gcc-only, but
easy to wrap on top of __func__):
https://www.redhat.com/archives/libvir-list/2010-May/msg00319.html
--
Eric Blake eblake(a)redhat.com +1-801-349-2682
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 619 bytes)