Re: [libvirt] [PATCH] New features implemented in hyperv libvirt driver

No answer ? De : Yves Vinter Envoyé : vendredi 26 septembre 2014 10:31 À : 'Eric Blake'; libvir-list(a)redhat.com Objet : RE: [libvirt] [PATCH] New features implemented in hyperv libvirt driver Hi Eric, As you know, the is no more development in hyperv libvirt driver since version 0.10.2. The last development was committed 2 years ago: 2012-09-06 Peter Krempa<http://libvirt.org/git/?p=libvirt.git;a=search;s=Peter+Krempa;s... hyperv: Add implementation for virConnectListAllDomains()<http://libvirt.org/git/?p=libvirt.git;a=com... tree<http://libvirt.org/git/?p=libvirt.git;a=tree;f=src/hyperv;hb=60d0... | commitdiff<http://libvirt.org/git/?p=libvirt.git;a=commitdiff;h=60d0ec... Subsequent commits are fixes for reported issues; the last commit has been done about 2 month ago: 2014-07-03 Ján Tomko<http://libvirt.org/git/?p=libvirt.git;a=search;s=J%C3%A1n+Tomko;... Use virBufferCheckError everywhere we report OOM error<http://libvirt.org/git/?p=libvirt.git;a=commit;h=92a8e72f9de5b4c... tree<http://libvirt.org/git/?p=libvirt.git;a=tree;f=src/hyperv;hb=92a8... | commitdiff<http://libvirt.org/git/?p=libvirt.git;a=commitdiff;h=92a8e7... Therefore, I didn’t miss any features … (verified after a sync) I understand that it would be easier for you to review the code to have the patch split by feature. I will make may best to help you in this way… Is that the last requirement ? Thanks, Yves. -----Message d'origine----- De : Eric Blake [mailto:eblake@redhat.com] Envoyé : jeudi 25 septembre 2014 18:59 À : Yves Vinter; libvir-list@redhat.com<mailto:libvir-list@redhat.comObjet : Re: [libvirt] [PATCH] New features implemented in hyperv libvirt driver On 09/25/2014 06:38 AM, Yves Vinter wrote: Please split each of these bulleted list items into a separate patch, for easier review. No one likes to review a 150k single patch. Also, it looks like you just missed feature freeze for 1.2.9; by the time you've split the series, it is probably a better candidate for inclusion in 1.2.10 around the end of October. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org