Re: [libvirt] [PATCH 03/16] virconf: add typed value accessor methods

Currently many users of virConf APIs are defining the same macros for calling virConfValue() and then doing type checking. To remove this repeated code, add a set of typesafe accessor methods.   Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com&gt; ---   src/libvirt_private.syms |  10 +   src/util/virconf.c       | 500 ++++++++++++++++++++++++++++++++++++++++++++++-   src/util/virconf.h       |  34 +++-   tests/virconftest.c      | 335 +++++++++++++++++++++++++++++++   4 files changed, 873 insertions(+), 6 deletions(-)

+/** + * virConfGetValueSSizeT: + * @conf: the config object + * @setting: the config entry name + * @value: pointer to hold integer value + * + * Get the integer value of the config name @setting, storing + * it in @value. If the config entry is not present, then + * @value will be unmodified. + * + * Reports an error if the config entry is set but has + * an unexpected type, or if the value is outside the + * range that can be stored in an 'ssize_t' + * + * Returns: 1 if the value was present, 0 if missing, -1 on error + */ +int virConfGetValueSSizeT(virConfPtr conf, +                          const char *setting, +                          ssize_t *value) +{ +    virConfValuePtr cval = virConfGetValue(conf, setting); + +    VIR_DEBUG("Get value ssize_t %p %d", +              cval, cval ? cval->type : VIR_CONF_NONE); + +    if (!cval) +        return 0; + +    if (cval->type != VIR_CONF_LONG && +        cval->type != VIR_CONF_ULONG) { +        virReportError(VIR_ERR_INTERNAL_ERROR, +                       _("%s: expected a signed integer for '%s' parameter"), +                       conf->filename, setting); +        return -1; +    } + +    if (cval->l > SSIZE_MAX || cval->l < (-SSIZE_MAX - 1)) { +        virReportError(VIR_ERR_INTERNAL_ERROR, +                       _("%s: value for '%s' parameter must be in range %zd:%zd"), +                       conf->filename, setting, -SSIZE_MAX - 1, SSIZE_MAX); +        return -1; +    }