Re: [PATCH 3/4] qemuxml2argvtest: Increase timeout on macOS
On Fri, 2020-11-13 at 16:58 +0100, Michal Privoznik wrote:
On 11/8/20 10:24 PM, Roman Bolshakov wrote:
> + if data['name'] == 'qemuxml2argvtest' and host_machine.system()
== 'darwin'
> + timeout = 180
> + else
> + # default meson timeout
> + timeout = 30
> + endif
> + test(data['name'], test_bin, env: tests_env, timeout: timeout)
I think the last time I wanted to increase the timeout I was told that
it is machine specific and since I know my machine the best I should
use: meson test --timeout-multiplier=X
Agreed: in my local test environment, for example, the test suite
completes successfully without tweaking the timeout at all. If the
Cirrus CI builders are slower and require a larger timeout that's
perfectly fine, but we should apply the tweak for that environment
only using the command line argument.
--
Andrea Bolognani / Red Hat / Virtualization