On Wed, Oct 14, 2020 at 12:26:57PM +0100, Daniel P. Berrangé wrote:
On Mon, Oct 12, 2020 at 07:35:36PM -0400, Nico Pache wrote:
> This will add the proper documentation and parser support for the free page
> reporting feature that is introduced in QEMU 5.1.
>
> Signed-off-by: Nico Pache <npache(a)redhat.com>
> ---
> docs/formatdomain.rst | 6 ++++++
> docs/schemas/domaincommon.rng | 5 +++++
> src/conf/domain_conf.c | 21 +++++++++++++++++++++
> src/conf/domain_conf.h | 1 +
> 4 files changed, 33 insertions(+)
>
> diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst
> index df5ac28028..e75b360b32 100644
> --- a/docs/formatdomain.rst
> +++ b/docs/formatdomain.rst
> @@ -6755,6 +6755,12 @@ Example: manually added device with static PCI slot 2
requested
> release some memory at the last moment before a guest's process get killed
by
> Out of Memory killer. :since:`Since 1.3.1, QEMU and KVM only`
>
> +``free-page-reporting``
> + The optional ``free-page-reporting`` attribute allows to enable/disable
> + ("on"/"off", respectively) the ability of the QEMU virtio
memory balloon to
> + return unused pages back to the hypervisor to be used by other guests or
> + processes. :since:`Since 5.1, QEMU and KVM only`
This has already been merged, but using hyphens in XML attribute names
is not common practice in libvirt. We usually use underscore, or
initialCaps styles.
I would say we can still change the naming as it was not released.
Pavel