Re: [RFC PATCH 5/5] qemu: Add suppport for amd-iommu device and xtsup attrib

Note that this is not a full review as I don't know how the iommu is behaving/used so I can't comment on that. On Fri, Sep 27, 2024 at 15:45:46 +0800, Han Han wrote: Please describe in the commit message what/why you are doing. e.g. at the very least when the new device is useful. E.g. the docs state that with certain config it allows > 255 cpus which would be great to mention in the commit message. I'd also prefer if the implementation of the new 'xtsup' attribute is separated. The docs also don't mention when to use the 'amd' model or which options don't actually work with it. (eim,caching-mode, etc) And lastly none of the new capability flags QEMU_CAPS_AMD_IOMMU* are used by this series, which they should be, as otherwise it makes no sense to add them.