Re: [PATCH 1/5] qemuOpenFileAs: Move into util/virqemu.c

On Mon, Aug 24, 2020 at 05:24:51PM +0200, Peter Krempa wrote: > On Mon, Aug 24, 2020 at 16:18:40 +0100, Daniel Berrange wrote: > > On Thu, Aug 06, 2020 at 11:55:12AM +0200, Peter Krempa wrote: > > > Signed-off-by: Peter Krempa <pkrempa(a)redhat.com&gt; > > > --- > > > src/libvirt_private.syms | 1 + > > > src/qemu/qemu_driver.c | 138 ++------------------------------------- > > > src/util/virqemu.c | 130 ++++++++++++++++++++++++++++++++++++ > > > src/util/virqemu.h | 7 ++ > > > 4 files changed, 144 insertions(+), 132 deletions(-) > > > > The original source files were not built on Win32, the new > > source files are. This causes a build failure due to... > > Sigh. I thought that I could make it to be an universal helper. Not very > useful, but universal. > > An alternative solution could be to dump it to qemu_domain.c ...

Yeah, I actually thought about this after sending the mail. It isn't used anywhere else outside of QEMU. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|