On 11/15/2011 04:35 AM, Daniel P. Berrange wrote:
From: "Daniel P. Berrange" <berrange(a)redhat.com>
Followup to
https://www.redhat.com/archives/libvir-list/2011-November/msg00580.html
This patch adds support for a systemd init service for libvirtd
and libvirt-guests. The libvirtd.service is *not* written to use
socket activation, since we want libvirtd to start on boot so it
can do guest auto-start.
Looks like you addressed all the v2 review comments.
ACK with one nit:
In v2:
- Fix AC_MSG_HELP wrapping
- Fix %makeinstall target
- Explicitly handle 'none' for --with-initscript
- Revert rename of libvirt-guests.sh
+ [AC_HELP_STRING([--with-init-script@<:@=STYLE@:>@],
+ [Style of init script to install: redhat, systemd,
systemd+redhat,
+ upstart, auto, none @<:@default=auto@:>@])])
+init_redhat=no
+init_systemd=no
+case "$with_init_script" in
+ systemd+redhat)
+ init_redhat=yes
+ init_systemd=yes
+ ;;
+ systemd)
+ init_systemd=yes
+ ;;
+ redhat)
+ init_redhat=yes
+ ;;
+ none)
+ ;;
+ *)
Where is upstart handled? Without an explicit clause, you might be
accidentally turning it into with_init_script=redhat.
--
Eric Blake eblake(a)redhat.com +1-919-301-3266
Libvirt virtualization library
http://libvirt.org