Re: [libvirt] [PATCH] Fix netdev detection on RHEL6x versions of qemu
On Tue, May 24, 2011 at 10:31:19AM +0100, Neil Wilson wrote:
On Tue, 2011-05-24 at 10:10 +0100, Daniel P. Berrange wrote:
> IMHO RHEL specific hacks don't belong in upstream libvirt code.
Currently there are checks against the qemu-kvm RHEL6 help files in the
test system of libvirt, and it is incorrect - as RHEL6 qemu uses netdev,
not add_host.
So why are you testing against the 'RHEL hacked' version of qemu if that
doesn't belong in upstream code?
Fundamentally if you install an up to date libvirt onto a RHEL6 machine,
the attach-interface code fails as there is no 'add_host' functionality
in the qemu version on that server. RHEL6 qemu uses netdev.
Attach-interface doesn't work when libvirt is compiled on RHEL6. You
have my proposal for fixing it. What is the alternative?
Use the libvirt that ships with RHEL6, or apply the RHEL6 specific
patches manually when building an alternative libvirt for RHEL6.
It isn't sustainable for upstream projects to deal with hacks for
every crazy non-upstream change that distros make. If distros choose
to change things in ways that diverge from upstream behaviour, then
it is their job to maintain the fixes for other code which breaks
as a result.
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|