Re: [libvirt] [patch 5/5] nwfilter: Extend docs with information about the comment attribute

Please respond to veillard On Fri, Oct 01, 2010 at 08:28:54PM -0400, Stefan Berger wrote: > I am adding a row with information about the newly supported state > attribute to each of the tables describing supported attributes

> > Signed-off-by: Stefan Berger <stefanb(a)us.ibm.com&gt; > > --- > docs/formatnwfilter.html.in | 30 ++++++++++++++++++++++++++++++ > 1 file changed, 30 insertions(+) > > Index: libvirt-acl/docs/formatnwfilter.html.in > =================================================================== > --- libvirt-acl.orig/docs/formatnwfilter.html.in > +++ libvirt-acl/docs/formatnwfilter.html.in > @@ -748,6 +748,11 @@ > <td>STRING</td> > <td>text with max. 256 characters</td> > </tr> > + <tr> > + <td>state <span class="since">(Since 0.8.5)</span></td> > + <td>STRING</td> > + <td>comma separated list of NEW,ESTABLISHED,RELATED,INVALID or NONE</td> > + </tr> > </table> Hum, I think the doc really ought to describe the semantic of the values, not just the allowed values, so IMHO that need to be refined explaining for example what "ESTABLISHED,RELATED" actually means would be useful :-)