Re: [libvirt] [PATCH 12/12] storage_util: Introduce storageBackendDoCreateQemuImg
On Tue, May 15, 2018 at 11:45:34AM -0400, John Ferlan wrote:
On 05/15/2018 10:35 AM, Peter Krempa wrote:
> On Tue, May 08, 2018 at 08:48:05 -0400, John Ferlan wrote:
>> Extract out command line setup and run from storageBackendCreateQemuImg
>> as we'll need to run it twice soon.
>
> Twice for one image creation? Or just two in general?
>
Twice for one creation, once for convert - it's bloody awful. That was
part of the email thread from the original patch, but a direct link is:
ITYM "Once for creation, twice for convert" - because convert has to
be done in terms of "qemu-img create" + "qemu-img convert -n"
https://www.redhat.com/archives/libvir-list/2018-April/msg02037.html
John
>>
>> Signed-off-by: John Ferlan <jferlan(a)redhat.com>
>> ---
>> src/storage/storage_util.c | 37 +++++++++++++++++++++++++++----------
>> 1 file changed, 27 insertions(+), 10 deletions(-)
>
> ACK
>
--
libvir-list mailing list
libvir-list(a)redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|