Re: [libvirt] [PATCH] Fix virsh {net,pool}-edit

"Daniel P. Berrange" <berrange(a)redhat.com&gt; wrote: > On Thu, Feb 12, 2009 at 04:58:50PM -0500, Cole Robinson wrote: >> The dumpxml commands for networks and pools don't support any flag >> arguments, and in fact explictly fail if flags != 0. This is not the >> case for vm dumpxml though, and flags were added to the base 'edit' >> implementation in virsh recently. >> >> The net and pool derivatives were not addressing this difference, so any >> net-edit or pool-edit attempt currently gives an error like: >> >> Network error : invalid argument in virNetworkGetXMLDesc >> >> The attached patch is one way to fix this. Thanks to Charles Duffy for >> the report. > Urgh, I rather dislike this code generation of the other edit > calls. It'd be much clearer if we justincluded the source for > them directly and had shared helper methods, rather than munging > source with perl. Hi Cole, I just chatted with Daniel off-line and he actually did like that patch, so you're welcome to commit it. ;-)