Re: [libvirt] [PATCH 3/7] fspools: configuration and internal representation

On Fri, Aug 19, 2016 at 06:03:31PM +0300, Olga Krishtal wrote: > Signed-off-by: Nikolay Shirokovskiy <nshirokovskiy(a)virtuozzo.com&gt; > --- > po/POTFILES.in | 1 + > src/Makefile.am | 5 + > src/conf/fs_conf.c | 1624 ++++++++++++++++++++++++++++++++++++++++++++++ > src/conf/fs_conf.h | 310 +++++++++ To go along with this could you create docs/schemas/{fspool,fsitem}.rng schema files, and corresponding docs/formatfs.html.in docs. Finally, we should have tests/fs{pool,item}xml2xmltest.c files which checks that we correctly round-trip the XML docs, with at least one example XML file for each schema.

> diff --git a/src/conf/fs_conf.c b/src/conf/fs_conf.c > new file mode 100644 > index 0000000..4906c86 > --- /dev/null > +++ b/src/conf/fs_conf.c > @@ -0,0 +1,1624 @@ > +/* > + * fs_conf.c: config handling for fs driver > + * > + */ Can you add the full LGPLv2+ boilerplate we normally have for files. Regards, Daniel