Re: [libvirt] [PATCH] complete virterror->virerror name change
Quoting Eric Blake (eblake(a)redhat.com):
On 01/30/2013 08:05 PM, Serge Hallyn wrote:
> Without these two string changes in generator.py, the
> virGetLastError wrapper does not get created in
> /usr/share/pyshared/libvirt.py. Noticed when running
> tests with virt-install.
>
> Signed-off-by: Serge Hallyn <serge.hallyn(a)ubuntu.com>
> ---
> python/generator.py | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
ACK.
Bummer - that means the python bindings are broken in the 1.0.2 release.
D'oh, with my patch, Chuck was also getting the following error:
chuck@homer:~/work/server/libvirt/libvirt-1.0.2/python/tests$ python error.py
Traceback (most recent call last):
File "error.py", line 35, in <module>
elif errno[0] == libvirt.VIR_ERR_NO_CONNECT or \
AttributeError: 'module' object has no attribute 'VIR_ERR_NO_CONNECT'
presumably because include/libvirt/virterror.h still exists, and my
patch was over-zealous.
-serge