Re: [libvirt] [PATCH RFC 0/8] qemu: allow disabling certain virtio revisions

On 07/29/2016 09:37 AM, Ján Tomko wrote: 1) I don't see anything in this series checking that the qemu binary recognizes the disable-legacy or disable-binary options for any of the devices. I don't know if both options were added to all devices in the same release (so that there could be a single capability flag) or if they were added at different times (requiring multiple capability flags). 2) To assure that the actual device presented to the guest doesn't change in the future when defaults are changed, we may want to autofill "version" even when none is specified. (We would of course be stuck with the unfortunate problem of what to do with existing configs) 3) Although there are curently only 2 versions, it may end up in the future that we want to specify something like "minVersion='1.0'" without giving a "maxVersion" (this would be useful in a template config to suppress IO port usage by the device without locking to a specific virtio version). Of course, it's possible that virtio 1.0 is perfect, and we'll never need another version :-) (seriously, since we'd *want* to lock down to a specific version as soon as the template config became a real config, I guess we can just have a version attribute now, and easily add (min|maxVersion) in the future if/when there is a virtio 2.0)