Re: [libvirt] [PATCH] python: Actually add virConnectGetVersion to generated bindings

On Wed, Feb 17, 2010 at 03:57:29PM -0500, Cole Robinson wrote: > The recent commit to implement a python version of this function > didn't drop an explicit 'ignore' check in the generator, so this > never ended up in the bindings. > > Signed-off-by: Cole Robinson <crobinso(a)redhat.com&gt; > --- > python/generator.py | 1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/python/generator.py b/python/generator.py > index 37c0169..24eaf50 100755 > --- a/python/generator.py > +++ b/python/generator.py > @@ -319,7 +319,6 @@ skip_function = ( > 'virConnectListDomains', # Python API is called virConectListDomainsID for unknown reasons > 'virConnSetErrorFunc', # Not used in Python API XXX is this a bug ? > 'virResetError', # Not used in Python API XXX is this a bug ? > - 'virConnectGetVersion', # Not used in Python API XXX is this a bug ? > 'virGetVersion', # Python C code is manually written > 'virSetErrorFunc', # Python API is called virRegisterErrorHandler for unknown reasons > 'virConnCopyLastError', # Python API is called virConnGetLastError instead urgh ! ACK Daniel