Re: [libvirt] [PATCH v2 5/7] tests: qemuxml2argv: Test formatting of 'write-cache' parameter

On Wed, Apr 18, 2018 at 11:38:45AM +0200, Peter Krempa wrote: > Signed-off-by: Peter Krempa <pkrempa(a)redhat.com&gt; > --- > .../disk-drive-write-cache.new.args | 43 +++++++++++++++++++++ > tests/qemuxml2argvdata/disk-drive-write-cache.xml | 45 ++++++++++++++++++++++ > tests/qemuxml2argvtest.c | 1 + > 3 files changed, 89 insertions(+) > create mode 100644 tests/qemuxml2argvdata/disk-drive-write-cache.new.args > create mode 100644 tests/qemuxml2argvdata/disk-drive-write-cache.xml

> diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c > index 75a9d0b908..2fa020675f 100644 > --- a/tests/qemuxml2argvtest.c > +++ b/tests/qemuxml2argvtest.c > @@ -1015,6 +1015,7 @@ mymain(void) > DO_TEST("disk-drive-cache-v2-none", NONE); > DO_TEST("disk-drive-cache-directsync", NONE); > DO_TEST("disk-drive-cache-unsafe", NONE); > + DO_TEST_CAPS_NEW("disk-drive-write-cache"); DO_TEST_VER with the earliest supported version would be IMO more beneficial. DO_TEST_CAPS_NEW might be nice to have.