Re: [libvirt] [PATCH] Don't free NULL network in cmdNetworkUpdate
On 27.08.2013 14:03, Laine Stump wrote:
On 08/26/2013 09:39 AM, Ján Tomko wrote:
> If the network has not been found, virNetworkFree(NULL)
> was called, resulting in an extra error:
> error: invalid network pointer in virNetworkFree
The patch is okay, but all vir*Free() functions should be NOPs when the
argument is NULL.
Just internal vir*Free() functions behave that way. The public ones,
like virNetworkFree() don't. I was thinking a while ago why we have
different approach like this, but the thought got buried under other stuff.
Michal