On Mon, Oct 25, 2010 at 03:30:49PM -0600, Eric Blake wrote:
On 10/24/2010 03:34 AM, Justin Clift wrote:
>Previously, only the API docs were installed, rather than the
>complete documentation set. This commit ensures the complete
>documentation set is installed.
>---
> docs/Makefile.am | 11 ++++++++++-
> 1 files changed, 10 insertions(+), 1 deletions(-)
>
>@@ -169,6 +174,10 @@ rebuild: api all
>
> install-data-local:
> $(mkinstalldirs) $(DESTDIR)$(HTML_DIR)
>+ for f in $(css) $(dot_html); do \
>+ $(INSTALL) -m 0644 $(srcdir)/$$f $(DESTDIR)$(HTML_DIR); done
>+ for f in $(gif) $(png); do \
>+ $(INSTALL) -m 0644 $(srcdir)/$$f $(DESTDIR)$(HTML_DIR); done
Any reason this is done as two for loops instead of one?
ACK once you rewrite this as:
for f in $(css) $(dot_html) $(gif) $(png); do \
$(INSTALL) -m 0644 $(srcdir)/$$f $(DESTDIR)$(HTML_DIR); done
ACK too, but I smell something missing as I don't see any reference
to those specific css files in the libvirt.spec.in file (only gtk-doc
ones seems copied and apparently that's not the same
Daniel
--
Daniel Veillard | libxml Gnome XML XSLT toolkit
http://xmlsoft.org/
daniel(a)veillard.com | Rpmfind RPM search engine
http://rpmfind.net/
http://veillard.com/ | virtualization library
http://libvirt.org/