Re: [libvirt] [PATCH 01/13] Introduce the function virCgroupForHypervisor

The subject should include 'v2' to mention that this is a respin; you can do that with 'git send-email --subject-prefix=PATCHv2'. On 07/10/2012 03:11 AM, tangchen wrote: So if I understand correctly, the intent is to create this hierarchy: cgroup mount point(s) (top-level controllers) - libvirt (subdirectory for all libvirt cgroups) --- qemu (all groups tied to a driver, virCgroupForDriver) ----- $name (all groups tied to a VM, virCgroupForDomain) ------- $vcpuN (one group per vcpu, virCgroupForVcpu) ------- hypervisor (one catchall group for non-vcpu, virCgroupForHypervisor) where hypervisor and vcpuN directories are siblings, both adding up to the sum total of $name for the VM totals. If so, please document that in the commit message. Still doesn't have the correct git authorship; git send-email would automatically insert a line: From: Wen Congyang <wency(a)cn.fujitsu.com&gt; if you had correctly attributed authorship. I can fix that as needed, though. Oops; gnulib submodule updates should generally be an independent patch, it looks like it was an accident that you bumped it on this patch. Other than that, this patch looks okay. -- Eric Blake eblake(a)redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org