Re: [libvirt] [PATCH v3 1/3] docs, conf, schema: add support for shmem device
On Wed, Oct 08, 2014 at 06:57:45PM +0200, Maxime Leroy wrote:
Hi Martin,
On Fri, Oct 3, 2014 at 10:45 PM, Martin Kletzander <mkletzan(a)redhat.com> wrote:
> On Thu, Oct 02, 2014 at 09:42:36AM +0200, Michal Privoznik wrote:
>>
>> On 26.09.2014 12:43, Martin Kletzander wrote:
>>>
>>> diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
>>> index b114737..51bdd31 100644
>>> --- a/src/conf/domain_conf.c
>>> +++ b/src/conf/domain_conf.c
>>
>>
[..]
>>
>
> Nice catch.
>
> Since we are past the release anyway, I'm going to push this in a
> while and whoever wants (e.g. Maxime) have the whole release cycle to
> test this.
>
Thanks for pushing/cleaning the shmem patches support (i.e
http://www.redhat.com/archives/libvir-list/2014-August/msg01032.html)
But you did miss the following:
1. the ivshmem server autostart feature: you wanted me to develop it
into the v1. (i.e.
http://www.redhat.com/archives/libvir-list/2014-August/msg01432.html)
Yes, I know. That was the idea that when the patches are split
logically, it's possible to push one part without waiting for other
one.
2. You did not wait for my tests. Why should I ask you to wait for my
tests?
Lucky enough, now I have the results of the tests, everything works fine ;)
I don't understand why it became so urgent to push these patches.
I'm sorry if I disappointed you somehow. At first I wanted to make it
for the 1.2.9 release, so we might get some upstream and usage from
libvirt users. Even though I didn't make it, I already had many
reviews and it was easy to fix what people requested. And because I
had some ACKs and it was after release, there's a whole release cycle
to try out for everyone else if they want (unfortunately they can't
try that with the official release, but have to go with git).
If you doubt that, it already worked. Thanks to pushing it, Eric
found some typos, Peter found out that there's no ABI stability check
in qemu driver and that's just a start.
Anyway, I am glad that libvirt supports ivshmem.
Since now you pushed these patches, do you plan to provide the ivshmem
autostart feature like you requested previously ?
I'll be glad to review it and to provide feedbacks based on my tests.
I did not plan to, so feel free to continue with that, I'm focusing on
different things now. But if it's updated in qemu and there's no
progress, I might look into that because it would be nice to have
libvirt supporting the server as well.
Have a nice day,
Martin
Attachments:
- signature.asc (application/pgp-signature — 819 bytes)