Re: [libvirt] [PATCH 30/31] nwfitler: Change the comment style
On 05/21/2013 04:01 AM, Osier Yang wrote:
The more common habit is to add the comment after the statements.
---
src/nwfilter/nwfilter_dhcpsnoop.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/nwfilter/nwfilter_dhcpsnoop.c b/src/nwfilter/nwfilter_dhcpsnoop.c
index b9921e5..451c783 100644
--- a/src/nwfilter/nwfilter_dhcpsnoop.c
+++ b/src/nwfilter/nwfilter_dhcpsnoop.c
@@ -369,7 +369,7 @@ virNWFilterSnoopListAdd(virNWFilterSnoopIPLeasePtr plnew,
for (pl = *end; pl && plnew->timeout < pl->timeout;
pl = pl->prev)
- /* empty */ ;
+ ; /* empty */
How did you determine which style was more common? Do you have 'git
grep | wc' numbers to back your claim? I guess putting the comment
after makes it easier to avoid false positives in patch 31?
I did notice a couple of empty while loops in earlier patches (let me
search for them again...)
found it: patch 8/31. Reply coming up there, soon.
ACK to all patches up to 30 where I didn't explicitly reply.
Weak ack to this one (I don't care if it goes in, but I also don't mind
if it gets omitted).
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 621 bytes)