[libvirt] [PATCH v3 14/14] qemu: Add flags to qemuMigrationWaitForCompletion
The function already takes two bool arguments, switching to flags makes
it a lot easier to read. Especially in case we need to add another
boolean in the future.
Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com>
---
Notes:
Version 3:
- no change
Version 2:
- moved to the end of the series since it is not required
by another patch in this series anymore
src/qemu/qemu_migration.c | 25 +++++++++++++------------
1 file changed, 13 insertions(+), 12 deletions(-)
diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c
index d67eca8..5bfd304 100644
--- a/src/qemu/qemu_migration.c
+++ b/src/qemu/qemu_migration.c
@@ -2760,21 +2760,14 @@ qemuMigrationWaitForCompletion(virQEMUDriverPtr driver,
virDomainObjPtr vm,
qemuDomainAsyncJob asyncJob,
virConnectPtr dconn,
- bool abort_on_error,
- bool storage)
+ unsigned int flags)
{
qemuDomainObjPrivatePtr priv = vm->privateData;
qemuDomainJobInfoPtr jobInfo = priv->job.current;
bool events = virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_MIGRATION_EVENT);
- unsigned int flags;
int rv;
- flags = QEMU_MIGRATION_COMPLETED_UPDATE_STATS |
- QEMU_MIGRATION_COMPLETED_POSTCOPY;
- if (abort_on_error)
- flags |= QEMU_MIGRATION_COMPLETED_ABORT_ON_ERROR;
- if (storage)
- flags |= QEMU_MIGRATION_COMPLETED_CHECK_STORAGE;
+ flags |= QEMU_MIGRATION_COMPLETED_UPDATE_STATS;
jobInfo->type = VIR_DOMAIN_JOB_UNBOUNDED;
while ((rv = qemuMigrationCompleted(driver, vm, asyncJob,
@@ -4469,6 +4462,7 @@ qemuMigrationRun(virQEMUDriverPtr driver,
bool abort_on_error = !!(flags & VIR_MIGRATE_ABORT_ON_ERROR);
bool events = virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_MIGRATION_EVENT);
bool inPostCopy = false;
+ unsigned int waitFlags;
int rc;
VIR_DEBUG("driver=%p, vm=%p, cookiein=%s, cookieinlen=%d, "
@@ -4654,9 +4648,17 @@ qemuMigrationRun(virQEMUDriverPtr driver,
fd = -1;
}
+ waitFlags = 0;
+ if (abort_on_error)
+ waitFlags |= QEMU_MIGRATION_COMPLETED_ABORT_ON_ERROR;
+ if (mig->nbd)
+ waitFlags |= QEMU_MIGRATION_COMPLETED_CHECK_STORAGE;
+ if (flags & VIR_MIGRATE_POSTCOPY)
+ waitFlags |= QEMU_MIGRATION_COMPLETED_POSTCOPY;
+
rc = qemuMigrationWaitForCompletion(driver, vm,
QEMU_ASYNC_JOB_MIGRATION_OUT,
- dconn, abort_on_error, !!mig->nbd);
+ dconn, waitFlags);
if (rc == -2)
goto cancel;
else if (rc == -1)
@@ -6268,8 +6270,7 @@ qemuMigrationToFile(virQEMUDriverPtr driver, virDomainObjPtr vm,
if (rc < 0)
goto cleanup;
- rc = qemuMigrationWaitForCompletion(driver, vm, asyncJob,
- NULL, false, false);
+ rc = qemuMigrationWaitForCompletion(driver, vm, asyncJob, NULL, 0);
if (rc < 0) {
if (rc == -2) {
--
2.7.2