Re: [libvirt PATCHv2 2/2] conf: require target for external virtiofsd
On Wed, Jun 16, 2021 at 20:25:44 +0200, Boris Fiuczynski wrote:
On 6/16/21 5:09 PM, Ján Tomko wrote:
> When adding support for externally launched virtiofsd,
> I was too liberal and did not require a target.
>
> But the target is required, because it's passed to the
> QEMU device, not to virtiofsd.
>
> https://bugzilla.redhat.com/show_bug.cgi?id=1969232
>
> Fixes: 12967c3e1333a6e106110f449ccb1e96279b9527
It actually fixes 56dcdec1ac8104f94371c210585bab91eb36395d which currently
breaks master.
Well, partially. It fixes indeed what Jano put in the commit message
originally, but as he pushed commits out of sequence it also introduced
another breakage.
The real intention is to fix that the virtiofs instance requires a
target even when it's running against a externally managed daemon.