Re: [libvirt] [PATCH v4 27/42] libxl: introduce virtxend daemon
On 8/8/19 9:10 AM, Daniel P. Berrangé wrote:
Arguably we could rename the libxl driver to "xen" since it
is the
only xen driver we have these days, and that matches how we expose it
to users in the URI naming.
While thinking about this today I realized it is actually quite a rat hole. I
started by making a list of tasks associated with the rename
- Replace 'libxl' with 'xen' in the docs
- Change configure option to '--with-xen' and drop '--with-libxl'
- Rename virt-driver-libxl.m4 to virt-driver-xen.m4
- Rename src/libxl to src/xen
- Rename src/xen/libxl_*.[ch] to src/xen/xen_*.[ch}
- Rename all the libxl files under tests/
These are easy enough, but should the list continue with renaming functions in
all those files? And what about things that are not so easy to rename, e.g.
runtime directories such as /etc/libvirt/libxl, /var/lib/libvirt/libxl/,
/var/log/libvirt/libxl, etc. Would renaming some things but leaving others cause
more confusion than the current situation?
Regardless of how far to go with renaming libxl to xen, I think moving the
xen<->libvirt config converter files from src/xenconfig to src/libxl and nuking
the xenconfig directory is a worthy endeavor.
Regards,
Jim