Re: [libvirt] [PATCH 1/2] xen: add error handling to UUID parsing

On 10/06/2011 11:36 AM, Guido Günther wrote: >>These three errors should probably all be changed away from >>VIR_ERR_INTERNAL_ERROR into something more useful, but I'm not sure >>whether that would be VIR_ERR_CONF_SYNTAX, >>VIR_ERR_CONFIG_UNSUPPORTED, or something else. > >I was uncertain about the error codes too, that's why I kept >VIR_ERR_INTERNAL_ERROR as used by other functions in this file. I'd >opt for VIR_ERR_CONF_SYNTAX. > -- Guido Yeah, for this particular case, where we are parsing a xen conf file, CONF_SYNTAX is the best fit. > >> >>ACK to the concept, once we decide on the correct error code. I think we've decided.