Re: [libvirt] [PATCH v5 2/2] conf: List only online cpus for virsh emulatorpin

On Fri, Nov 25, 2016 at 14:53:07 +0530, Nitesh Konkar wrote: Adding conditionally compiled code twice does not look good. Please extract the above into a helper function and use it in the two places rather than having two blocks of conditional code. Also I'm not entirely perusaded that this is correct. When you are getting information for the offline VM the configuration may change until you start the VM and thus the data gathered here will not be valid. (e.g. if you turn the cpus back on) For running VMs the data depends on the state when the VM was started and at least for vcpu threads is gathered back using virProcessGetAffinity and thus should be reported correctly. Additionally we historically treat the "all bits set" cpu map as that there is no pinning configured. This would change this behavior. When the VM is started, the real cpu map should be returned, but for the config time I think the current state is correct and doing your change would be incorrect. Peter