Re: [libvirt] [PATCH 2/4] libvirt-guest.init: quoting variables

Hello Eric, On Friday Mar 11th 2011 21:48:03 Eric Blake wrote: I would call it root-configurable instead of user-settable, because that file is normally owned by root and has mod 0644. A sane root hopefully does not put a 'rm -rf /' in there ;-) It would be something else if that file was sourced by a program running with more privileges than the user, who is allowed to edit that file. But yes, even root should expect decent bahavior and should not be surprised by the shell expanding string containing wildcards. I've seen to many scripts not doing any quoting at all or all wrong, which fail in interesting to horrible ways when given arguments containing shell meta characters. I personally consider them a much greater risk than some ancient shell not being able to parse properly quoted strings. My rule of thumb is this: if the command dominfo is expecting one argument, I make sure it gets exactly on argument by properly quoting it. I don't care that I know that it will normally not contain blanks or wildcard, so even when someone other later changes the variable in some stupid way, it will still pass one required argument to the function. I prefer virsh to report an error like "'foo bar' is invalid" instead of "'foo' not found" or 'unexpected additional parameter "bar"'. I'm waiting for the day when someone dictates, that the UNIXroot-directory is no longer called '/' but '/ /'. That will give some lovely firefork ;-) Only #1 was the really important fix, the others were done because I was already looking for whitespace problems. To thanks for applying this one two. Sincerely Philipp -- Philipp Hahn Open Source Software Engineer hahn(a)univention.de Univention GmbH Linux for Your Business fon: +49 421 22 232- 0 Mary-Somerville-Str.1 D-28359 Bremen fax: +49 421 22 232-99 http://www.univention.de/