Re: [libvirt] [PATCHv2 04/27] libvirt-qemu: use unsigned flags
On 07/13/2011 03:54 AM, Matthias Bolte wrote:
2011/7/8 Eric Blake <eblake(a)redhat.com>:
> Like commit 1740c381, but for libvirt-qemu.
>
> * src/remote/qemu_protocol.x (qemu_monitor_command_args): Adjust
> type to match API.
> * src/qemu_protocol-structs: Update accordingly.
> ---
>
> v2: new patch
>
> src/qemu_protocol-structs | 2 +-
> src/remote/qemu_protocol.x | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
Should we have a syntax-check rule to enforce unsigned int flags in
the RPC protocol like you added a rule to do this in the public API.
The syntax-check rule in 27/27 should cover this - it will complain if
we introduce a 'int flags;' in any of the *protocol.x files, which
should prod us to use 'unsigned int flags;' instead.
Or are you referring to the fact that patch 27/27 only checked
libvirt.h.in for additions of '...long flags', to ensure that no more
than the existing 4 uses for migration are added? In that case, yeah,
that rule can be enhanced to check include/libvirt/libvirt-qemu.h as
well, to ensure that all new public APIs, whether for libvirt proper or
for libvirt-qemu, use 'unsigned int flags'. But that's a tweak to 27,
not to this one, so I pushed 4/27 as-is.
ACK.
--
Eric Blake eblake(a)redhat.com +1-801-349-2682
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 619 bytes)