Re: [Libvir] [PATCH] sound support for qemu and xen
On Mon, Apr 21, 2008 at 01:02:35PM -0400, Cole Robinson wrote:
The patch below adds xml support for the soundhw option to qemu
and xen. The new xml element takes the form:
<sound driver='drivername'/>
Where driver name can be pcspk, sb16, es1370, or all.
I'd like to use 'model' instead of 'driver', since we use
'model' in the network driver to specify the type of hardware
and will do the same with disks too in the future.
ie
<sound model='sb16'/>
Everything seems to be in working order but I have a few
implementation questions:
1) Should multiple drivers be able to be specified? qemu
accommodates this, allowing '-soundhw sb16,pcspk' for example.
If this should be allowed, what should the xml format be?
It should be represented as multiple <source> tags in the XML.
The fact that is multiplexes onto a single -soundhw arg is an
implementation detail that should remain hidden.
2) Should acceptable driver options be hardcoded? The other option
is to just pass the input straight to qemu. This patch has the
options hardcoded.
I prefer to have it hardcoded because it lets us explicitly block
the string 'all'. The string 'all' is an implementation detail to
which no reliable semantics can be assigned and should not be allowed
by libvirt.
Regards,
Dan.
--
|: Red Hat, Engineering, Boston -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|