This patchset finishes the conversion to virConfGetValue* functions,
started by Daniel Berrange a few months ago.
Please, mind that although we could make virConfGetValue* functions more
generic in order to support numbers and booleans as strings, that
doesn't seem the safest path to take. The side-effect of this is that we
will have to live with some specific code doing that as part of vmx and
xen_common.
Once this patchset gets merged,
https://wiki.libvirt.org/page/BiteSizedTasks#Finish_conversion_to_virConf...
can be removed.
- Changes since v1:
All the "values" from virConfGetValueString() are freed
- Changes since v2:
All comments from Ján Tomko have been addressed;
A few leaks were (possibly) found and they're addressed in the last
patch of the series;
- Changes since v3:
All comments from Ján Tomko have been addressed in order to lower the
non-whitespace changes in the first patch;
- Changes since v4:
All comments from Ján Tomko have been addressed (hopefully, they
actually were this time :-));
- Changes since v5:
All comments from John Ferlan have been addressed, including splitting
the patches per "function" touched. Some new patches were also needed
due to a behaviour change introduced by the "xen_common: Change
xenParsePCIList to using virConfGetValueStringList" patch.
Fabiano Fidêncio (15):
xen_common: Change xenConfigCopyStringInternal to using
virConfGetValueString
xen_common: Change xenConfigGetUUID to using virConfGetValueString
xen_common: Change xenConfigGetString to using virConfGetValueString
xen_xl: Adapt xenParseCmdline due to changes in xenConfigGetString
xen_xl: Adapt xenParseXLOS due to changes in xenConfigGetString
xen_xl: adapt xenParseXLCPUID due to changes in xenConfigGetString
xen_common: Adapt xenParseEventsActions due to changes in
xenConfigGetString
xen_common: Adapt xenParseCPUFeatures due to changes in
xenConfigGetString
xen_common: Adapt xenParseEmulatedDevices due to changes in
xenConfigGetString
xen_common: Adapt xenParseGeneralMeta due to changes in
xenConfigGetString
xen_xm: Adapt xenParseXMOS due to changes in xenConfigGetString
xen_xm: Adapt xenParseXMInputDevs due to changes in xenConfigGetString
xen_common: Change xenParsePCIList to using virConfGetValueStringList
xen_common: Change xenParseVfbs to using virConfGetValueStringList
xen_common: Change xenParseCharDev to using virConfGetValueStringList
src/xenconfig/xen_common.c | 223 +++++++++++++++++++------------------
src/xenconfig/xen_xl.c | 71 +++++++-----
src/xenconfig/xen_xm.c | 48 ++++----
3 files changed, 186 insertions(+), 156 deletions(-)
--
2.17.1