Re: [libvirt] [PATCH v2] Makefile: Fix parallel build after Xen-xl parser introduction
On 01/06/2015 06:47 AM, Michal Privoznik wrote:
Well, the parallel build doesn't work as there are not
dependencies
set correctly. When running 'make -j' I see this error:
make[2]: Entering directory '/home/zippy/work/libvirt/libvirt.git/src'
GEN util/virkeymaps.h
GEN locking/lock_protocol.h
make[2]: *** No rule to make target 'xenconfig/xen_xl_disk.h', needed by
'all'. Stop.
make[2]: *** Waiting for unfinished jobs....
GEN lxc/lxc_controller_dispatch.h
The fix is to correctly set dependencies by letting make know that .c
and .h are to be generated from .l. Moreover, the section is moved
closer to the other section which uses it.
Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com>
---
This is reworked version of my first patch. The difference is
that I'm using a stamp this time.
Still fails in a VPATH build :(
make[2]: Entering directory '/home/eblake/libvirt-tmp/build4/src'
/bin/sh ../../build-aux/ylwrap ../../src/xenconfig/xen_xl_disk.l
lex.yy.c xenconfig/xen_xl_disk.c -- flex -Pxl_disk_
--header-file=../xenconfig/xen_xl_disk.h
lex.xl_disk_.c is unchanged
make all-am
Note that the rule tried to reference
--header-file=../xenconfig/xen_xl_disk.h, but that is not a file under
version control. Generated files should (normally) be placed into
builddir, not srcdir, unless we plan on making those generated files be
part of the tarball (which in turn implies the generated file can be
built identically regardless of configure options, for a maintainer with
sufficient tools).
I'm still playing with it, to see if I can fix the issues.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 604 bytes)