Re: [libvirt] [PATCH 19/24] qemu: command: Unify retrieval of NUMA cell count in qemuBuildNumaArgStr

On 02/16/2015 01:52 PM, Peter Krempa wrote: > The function uses the cell count in 6 places. Add a temp variable to > hold the count as it will greatly simplify the refactor. > --- > src/qemu/qemu_command.c | 13 +++++++------ > 1 file changed, 7 insertions(+), 6 deletions(-) > ACK - had to peek forward a few patches to "see" why this becomes important though ;-)... I did ask myself - was there anything from the time it's defined/pulled from def->cpu->ncells to each time it was where the 'ncells' could change (I don't think so, but it does cross my mind when I see these).