Re: [libvirt] [PATCH v4 1/5] blockjob: allow omitted arguments to QMP block-commit

On 06/24/14 01:30, Eric Blake wrote: > We are about to turn on support for active block commit. Although > qemu 2.0 was the first version to mostly support it, that version > mis-handles 0-length files, and doesn't have anything available for > easy probing. But qemu 2.1 fixed bugs, and made life simpler by > letting the 'top' argument be optional. Unless someone begs for > active commit with qemu 2.0, for now we are just going to enable > it only by probing for qemu 2.1 behavior (anyone backporting active > commit can also backport the optional argument behavior). >

> * src/qemu/qemu_monitor.h (qemuMonitorSupportsActiveCommit): New > prototype. > * src/qemu/qemu_monitor.c (qemuMonitorSupportsActiveCommit): > Implement it. > * src/qemu/qemu_monitor_json.h (qemuMonitorJSONBlockCommit): > Allow NULL for top and base, for probing purposes. > * src/qemu/qemu_monitor_json.c (qemuMonitorJSONBlockCommit): > Likewise, implementing the probe. > * tests/qemumonitorjsontest.c (mymain): Enable... > (testQemuMonitorJSONqemuMonitorSupportsActiveCommit): ...a new test. >

ACK,