[libvirt] [PATCH v2 1/5] uml: Fix umlProcessAutoDestroyDom dom processing
There's no need to check if @dom exists before trying to
call virDomainObjListRemove since it must exist due to
prior checks.
Additionally, if we do remove the @dom, then set it to NULL
so that the virObjectUnlock isn't referencing something that
is deleted.
Signed-off-by: John Ferlan <jferlan(a)redhat.com>
---
src/uml/uml_driver.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/uml/uml_driver.c b/src/uml/uml_driver.c
index ab7fa7f273..ff2e7ac66b 100644
--- a/src/uml/uml_driver.c
+++ b/src/uml/uml_driver.c
@@ -747,8 +747,10 @@ static int umlProcessAutoDestroyDom(void *payload,
VIR_DOMAIN_EVENT_STOPPED,
VIR_DOMAIN_EVENT_STOPPED_DESTROYED);
- if (dom && !dom->persistent)
+ if (!dom->persistent) {
virDomainObjListRemove(data->driver->domains, dom);
+ dom = NULL;
+ }
if (dom)
virObjectUnlock(dom);
--
2.13.6