Re: [PATCH 0/3] Rmove support of tftp storage protocol

On Thu, May 21, 2020 at 5:21 PM Daniel P. Berrangé <berrange(a)redhat.com <mailto:berrange@redhat.com>> wrote: On Thu, May 21, 2020 at 04:05:47PM +0800, Han Han wrote: > On Thu, May 21, 2020 at 2:44 PM Peter Krempa <pkrempa(a)redhat.com <mailto:pkrempa@redhat.com>> wrote: > > > On Thu, May 21, 2020 at 14:08:17 +0800, Han Han wrote: > > > Let's drop tftp support since it is ususabled before or after QEMU v2.8 > > > [1]. > > > > > > [1]: https://bugzilla.redhat.com/show_bug.cgi?id=1372143 > > > > > > > > > Han Han (3): > > >   docs: Remove tftp protocol support from docs > > >   src: Remove tftp network storage support > > >   news: Remove support for tftp storage protocol > > > > NACK series: > > > > 1) qemu 2.8 is still supported by libvirt > > > However, the tftp is actually unusable for all versions of qemu, while the > formatdomain doc > states that it is optional protocol Do you have any more information on this. I'd be surprised if it was /always/ unusuable, as opposed to initially working and then getting broken in some particular version of QEMU. I tested on qemu-kvm-1.5.3-174.el7.x86_64 curl-7.29.0-58.el7.x86_64 tftp-server-5.2-22.el7.x86_64, it doesn't work, either: ➜  ~ curl tftp://127.0.0.1/img <http://127.0.0.1/img> -o /tmp/tftp                                   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current                                  Dload  Upload   Total   Spent    Left  Speed 100  100M  100  100M    0     0  20.6M      0  0:00:04  0:00:04 --:--:-- 20.6M 100  100M  100  100M    0     0  20.6M      0  0:00:04  0:00:04 --:--:-- 20.6M ➜  ~ qemu-img create -f qcow2 -b 'json:{"file.driver":"tftp", "file.url":"tftp://127.0.0.1/img <http://127.0.0.1/img>"}' /var/lib/libvirt/images/tftp.img Formatting '/var/lib/libvirt/images/tftp.img', fmt=qcow2 size=104857600 backing_file='json:{"file.driver":"tftp", "file.url":"tftp://127.0.0.1/img <http://127.0.0.1/img>"}' encryption=off cluster_size=65536 lazy_refcounts=off ^C ➜  ~ qemu-img info 'json:{"file.driver":"tftp", "file.url":"tftp://127.0.0.1/img <http://127.0.0.1/img>"}' ^C The qemu-img command above is stuck and never returns. Max, is the tftp unusable for all versions of QEMU? Could you please give more info on that?