Re: [PATCH 1/2] gitlab: introduce CI jobs for building content
On Fri, May 15, 2020 at 07:15:55PM +0200, Andrea Bolognani wrote:
On Fri, 2020-05-15 at 17:37 +0100, Daniel P. Berrangé wrote:
> +ubuntu-2004-container:
> + <<: *container_job_definition
> + variables:
> + NAME: ubuntu-2004
> +
> +
> +
Way too many empty lines here :)
> +# ubuntu-2004-docs is special as it is the one
> +# we publish from
> +pages:
> + <<: *docs_job_definition
> + variables:
> + NAME: ubuntu-2004
> + artifacts:
> + paths:
> + - public
It's kinda weird that this one has a different name despite being
part of the same stage... Maybe ubuntu-2004-pages? Either way you're
going to have to update the comment to reflect the actual name of
the job.
It has to have exactly the name "pages", as this is what triggers
gitlab to consider it the publishing job.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|