Re: [libvirt] [PATCHv2 5/7] conf: track sizes directly in source struct

One of the features of qcow2 is that a wrapper file can have more capacity than its backing file from the guest's perspective; what's more, sparse files make tracking allocation of both the active and backing file worthwhile. As such, it makes more sense to show allocation numbers for each file in a chain, and not just the top-level file. This sets up the fields for the tracking, although it does not modify XML to display any new information. * src/util/virstoragefile.h (_virStorageSource): Add fields. * src/conf/storage_conf.h (_virStorageVolDef): Drop redundant fields. * src/storage/storage_backend.c (virStorageBackendCreateBlockFrom) (createRawFile, virStorageBackendCreateQemuImgCmd) (virStorageBackendCreateQcowCreate): Update clients. * src/storage/storage_driver.c (storageVolDelete) (storageVolCreateXML, storageVolCreateXMLFrom, storageVolResize) (storageVolWipeInternal, storageVolGetInfo): Likewise. * src/storage/storage_backend_fs.c (virStorageBackendProbeTarget) (virStorageBackendFileSystemRefresh) (virStorageBackendFileSystemVolResize) (virStorageBackendFileSystemVolRefresh): Likewise. * src/storage/storage_backend_logical.c (virStorageBackendLogicalMakeVol) (virStorageBackendLogicalCreateVol): Likewise. * src/storage/storage_backend_scsi.c (virStorageBackendSCSINewLun): Likewise. * src/storage/storage_backend_mpath.c (virStorageBackendMpathNewVol): Likewise. * src/storage/storage_backend_rbd.c (volStorageBackendRBDRefreshVolInfo) (virStorageBackendRBDCreateImage): Likewise. * src/storage/storage_backend_disk.c (virStorageBackendDiskMakeDataVol) (virStorageBackendDiskCreateVol): Likewise. * src/storage/storage_backend_sheepdog.c (virStorageBackendSheepdogBuildVol) (virStorageBackendSheepdogParseVdiList): Likewise. * src/storage/storage_backend_gluster.c (virStorageBackendGlusterRefreshVol): Likewise. * src/conf/storage_conf.c (virStorageVolDefFormat) (virStorageVolDefParseXML): Likewise. * src/test/test_driver.c (testOpenVolumesForPool) (testStorageVolCreateXML, testStorageVolCreateXMLFrom) (testStorageVolDelete, testStorageVolGetInfo): Likewise. * src/esx/esx_storage_backend_iscsi.c (esxStorageVolGetXMLDesc): Likewise. * src/esx/esx_storage_backend_vmfs.c (esxStorageVolGetXMLDesc) (esxStorageVolCreateXML): Likewise. * src/parallels/parallels_driver.c (parallelsAddHddByVolume): Likewise. * src/parallels/parallels_storage.c (parallelsDiskDescParseNode) (parallelsStorageVolDefineXML, parallelsStorageVolCreateXMLFrom) (parallelsStorageVolDefRemove, parallelsStorageVolGetInfo): Likewise. * src/vbox/vbox_tmpl.c (vboxStorageVolCreateXML) (vboxStorageVolGetXMLDesc): Likewise. * tests/storagebackendsheepdogtest.c (test_vdi_list_parser): Likewise. * src/phyp/phyp_driver.c (phypStorageVolCreateXML): Likewise. --- src/conf/storage_conf.c | 10 ++++----- src/conf/storage_conf.h | 3 --- src/esx/esx_storage_backend_iscsi.c | 5 +++-- src/esx/esx_storage_backend_vmfs.c | 20 ++++++++--------- src/parallels/parallels_driver.c | 2 +- src/parallels/parallels_storage.c | 22 +++++++++---------- src/phyp/phyp_driver.c | 4 ++-- src/storage/storage_backend.c | 24 ++++++++++---------- src/storage/storage_backend_disk.c | 6 ++--- src/storage/storage_backend_fs.c | 6 ++--- src/storage/storage_backend_gluster.c | 6 ++--- src/storage/storage_backend_logical.c | 10 +++++---- src/storage/storage_backend_mpath.c | 6 ++--- src/storage/storage_backend_rbd.c | 11 +++++----- src/storage/storage_backend_scsi.c | 4 ++-- src/storage/storage_backend_sheepdog.c | 10 ++++----- src/storage/storage_driver.c | 40 +++++++++++++++++----------------- src/test/test_driver.c | 16 +++++++------- src/util/virstoragefile.h | 2 ++ src/vbox/vbox_tmpl.c | 11 +++++----- tests/storagebackendsheepdogtest.c | 5 +++-- 21 files changed, 114 insertions(+), 109 deletions(-)