Re: [libvirt] [python PATCH] maint: balance {} usage
On 03/24/2014 12:09 PM, Peter Krempa wrote:
On 03/24/14 18:03, Eric Blake wrote:
> Emacs gets lost when finding function boundaries when #ifdef
> sections do not have balanced {}.
>
> * libvirt-override.c (virPyDictToTypedParams): Avoid unbalanced {}
> across ifdef.
>
> Signed-off-by: Eric Blake <eblake(a)redhat.com>
> ---
>
> This feels trivial, but it's also hacky enough that I'll wait
> for a review.
IMHO a little less hacky solution would be to break the coding style and
move the opening curly brace after the #endif section and thus avoid the
extra if statement and the comment
Or even hoist the #ifdef outside of the function. I'll post a v2.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 604 bytes)