On Thu, Sep 04, 2008 at 01:32:57PM +0200, Jim Meyering wrote:
"Daniel P. Berrange" <berrange(a)redhat.com> wrote:
...
> Attached is a version with that change - though I had to make it 'int' for
> the return type since uid_t/gid_t don't exist on mingw either. Not that
> it matters, since we store the result in an int anyway
...
> if [ -f /usr/bin/rpmbuild ]; then
> if [ -n "$AUTOBUILD_COUNTER" ]; then
> EXTRA_RELEASE=".auto$AUTOBUILD_COUNTER"
> @@ -51,5 +50,40 @@ if [ -f /usr/bin/rpmbuild ]; then
> NOW=`date +"%s"`
> EXTRA_RELEASE=".$USER$NOW"
> fi
> - rpmbuild --nodeps --define "extra_release $EXTRA_RELEASE" -ta --clean
*.tar.gz
> +
> + rpmbuild --nodeps \
> + --define "extra_release $EXTRA_RELEASE" \
> + --define "_sourcedir `pwd`" \
> + -ba --clean libvirt.spec
> +fi
> +
> +if [ -x /usr/bin/i686-pc-mingw32-gcc ]; then
> + make distclean
> +
> +
PKG_CONFIG_PATH=$AUTOBUILD_INSTALL_ROOT/i686-pc-mingw32/sys-root/mingw/lib/pkgconfig \
> + CC="i686-pc-mingw32-gcc" \
you might want to omit the unnecessary double quotes here,
to be consistent e.g., with host=i686... below.
> + ./configure \
> + --build=$(uname -m)-pc-linux \
> + --host=i686-pc-mingw32 \
> + --prefix=$AUTOBUILD_INSTALL_ROOT/i686-pc-mingw32/sys-root/mingw \
Here, however, you should add quotes around $AUTOBUILD_INSTALL_ROOT,
since it's coming from the environment and may contain spaces or worse.
--prefix="$AUTOBUILD_INSTALL_ROOT/i686-pc-mingw32/sys-root/mingw" \
I've made these two changes and committed the patch.
Daniel
--
|: Red Hat, Engineering, London -o-
http://people.redhat.com/berrange/ :|
|:
http://libvirt.org -o-
http://virt-manager.org -o-
http://ovirt.org :|
|:
http://autobuild.org -o-
http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|