Re: [libvirt] [PATCH v2] Link libvirt_util with datatypes
On Wed, Apr 15, 2015 at 02:29:52PM +0200, Martin Kletzander wrote:
Most of the types in datatypes.[hc] depend on virObject and
virClass,
but they were specified separatedly from that. We were lucky enough for
this to work because wherever the datatypes files were used, that
file (binary/shared object) was linked to libvirt_util as well.
Fixing this comes up as a pretty nice cleanup.
I'm not really seeing what problem needs fixing here. The libvirt_util
library doesn't depend on the datatypes file, and everything that we
build links to libvirt_util, so AFAIK there's nothing that needs fixing
libvirt_util.la doesn't depend on datatypes.h - at least it shouldn't
unless we regressed somewhere.
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|