Re: [libvirt] [PATCH] maint: Fix incorrect parenthesis placement causing true/false assignment

There were a few places in our code where the following pattern in 'if' condition occurred: if ((foo = bar() < 0)) do something; This patch adjusts the conditions to the expected format: if ((foo = bar()) < 0) do something;

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1488192 Signed-off-by: Erik Skultety <eskultet(a)redhat.com&gt; --- This can be especially "fun" if you try to assign multiple RNG devices to a domain and then try to hot-unplug any of them but the first. Anyhow I used the regex below to find these, I haven't spent much time tuning in, so in case you can come up with a better one that yields more results like these I'm all ears :). [[:alnum:]_]+ = [[:print:]]+[^)]) < 0))