Re: [PATCH v1] meson: fix xenstore and xentoollog detection
On 6/16/21 8:50 AM, Olaf Hering wrote:
Am Mon, 14 Jun 2021 14:38:19 +0100
schrieb Daniel P. Berrangé <berrange(a)redhat.com>:
> Based on this policy, it is clear that the Xen minimum should be
> 4.9 based on version information we can see for the distros.
Just to wrap up here:
The LIBXL_API_VERSION needs to stay at 4.5, because this is the only thing known by Xen
4.9.
It's the only LIBXL_API_VERSION known to Xen 4.5-4.12 :-).
As a result no code can be removed.
There are 4 LIBXL_HAVE_whatever knobs that appeared between Xen 4.6 and 4.9.
As a result only a few lines of #ifdef/#endif could be removed, no actual code.
Sadly, not much can be changed until the minimum supported version can be bumped
to 4.13.
So in my opinion it is not worth the effort, the patch for
meson.build should be applied as it is.
We are stuck with the 4.5 API through 4.12, but we can still take advantage of
other integration-related improvements in Xen such as pkgconfig files. E.g. the
attached patch bumps the minimum version to 4.9, which should take care of your
issue and makes for one less conditional in meson.build. Opinions?
Regards,
Jim
Attachments:
- 0001-Xen-Bump-minimum-supported-Xen-version-to-4.9.patch (text/x-patch — 1.9 KB)