Re: [libvirt] [PATCH 05/13] qemu: Auto add pci-root for s390/s390x guests

On Thu, May 24, 2018 at 02:24:30PM +0200, Xiao Feng Ren wrote: > From: Yi Min Zhao <zyimin(a)linux.ibm.com&gt; > > The pci-root depends on zpci capability. So autogenerate pci-root if > zpci exists. > > Signed-off-by: Yi Min Zhao <zyimin(a)linux.ibm.com&gt; > Reviewed-by: Boris Fiuczynski <fiuczy(a)linux.vnet.ibm.com&gt; > Reviewed-by: Stefan Zimmermann <stzi(a)linux.ibm.com&gt; > Reviewed-by: Bjoern Walk <bwalk(a)linux.vnet.ibm.com&gt; > --- > src/qemu/qemu_domain.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c > index ee676a2789..05136540aa 100644 > --- a/src/qemu/qemu_domain.c > +++ b/src/qemu/qemu_domain.c > @@ -3068,6 +3068,7 @@ qemuDomainDefAddDefaultDevices(virDomainDefPtr > def, >     case VIR_ARCH_S390X: >         addDefaultUSB = false; >         addPanicDevice = true; > +        addPCIRoot = virQEMUCapsGet(qemuCaps, QEMU_CAPS_DEVICE_ZPCI); So from a certain QEMU version all the S390 machine types have an implicit PCI root?

Is migration a thing on S390?

Jano >         break; > >     case VIR_ARCH_SPARC: > -- > 2.16.3 > > -- > libvir-list mailing list > libvir-list(a)redhat.com > https://www.redhat.com/mailman/listinfo/libvir-list