Re: [libvirt] [PATCH] qemu: remove memset params array to zero in qemuDomainGetPercpuStats
On Wed, Jan 15, 2014 at 04:47:21PM +0800, Gao feng wrote:
the array params is allocated by VIR_ALLOC_N in cmdCPUStats.
it had been set to zero. No need to reset it to zero again,
and this reset here is incorrect too, nparams * ncpus is the
array length not the size of params array.
'cmdCPUStats' is virsh client code. The QEMU driver is
running server side in libvirtd. So whatever memory was
allocated in cmdCPUStats isn't the same as the memory
used in qemu_driver.c
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|