Re: [libvirt] [PATCH v2 16/21] conf: Don't store vcpusched orthogonally to other vcpu info

Due to bad design the vcpu sched element is orthogonal to the way how the data belongs to the corresponding objects. Now that vcpus are a struct that allow to store other info too, let's convert the data to the sane structure. The helpers for the conversion are made universal so that they can be reused for iothreads too. This patch also resolves https://bugzilla.redhat.com/show_bug.cgi?id=1235180 since with the correct storage approach you can't have dangling data. --- src/conf/domain_conf.c | 246 +++++++++++++++++++++++++++++++++++++++--------- src/conf/domain_conf.h | 5 +- src/qemu/qemu_driver.c | 6 +- src/qemu/qemu_process.c | 8 +- 4 files changed, 214 insertions(+), 51 deletions(-)

@@ -21465,6 +21504,143 @@ virDomainDefHasCapabilitiesFeatures(virDomainDefPtr def) } +/** + * virDomainFormatSchedDef: + * @def: domain definiton + * @buf: target XML buffer + * @name: name of the target XML element + * @func: function that returns the thread scheduler parameter struct for an object + * @resourceMap: bitmap of indexes of objects that shall be formated (used with @func