Re: [PATCH 2/4] tests: more fine-granular tests for virtio-options
On 4/27/20 4:41 PM, Bjoern Walk wrote:
Michal Privoznik <mprivozn(a)redhat.com> [2020-04-27, 12:06PM
+0200]:
> Impressive. But should we turn these into DO_TEST_CAPS_LATEST() and
> DO_TEST_CAPS_LATEST_FAILURE() respectively? That would need to be followed
> by .args rename but I'm okay doing both locally if you agree.
Hmm, I am still a bit fuzzy on the semantics for the _LATEST() tests.
For the positive tests, I guess that's fine, I don't see any
side-effects with other capabilities. But how does it work with the
negative tests? Can we switch off a capability here, or am I
misunderstanding something? But yes, if it's working, I don't see a
reason not to change it, even better, if you do the work :)
Ah, I thought we are testing different XMLs but we are really testing
the same XMLs with a different set of capabilities. Yeah, we can change
the DO_TEST_CAPS_LATEST() then. The negative tests should stay as they
are. Sorry for the noise.
Michal