Re: [libvirt] [PATCH 2/2] virsh: Document bandwidth maximum more clearly
On 07/17/14 01:35, John Ferlan wrote:
Commit id '0e2d7305' modified the code to allow a negative
value to be
supplied for the bandwidth argument of the various block virsh commands
Technically that commit didn't allow it. It was allowed before that
commit kept it in that same state.
and the migrate-setspeed; however, it failed to update the man page
to
describe the "feature" whereby a very large value could be interpreted
by the hypervisor to mean maximum value allowed. Although initially
designed to handle a -1 value, the reality is just about any negative
value could be provided and essentially perform the same feature.
Signed-off-by: John Ferlan <jferlan(a)redhat.com>
---
tools/virsh.pod | 23 +++++++++++++++++++----
1 file changed, 19 insertions(+), 4 deletions(-)
ACK, I like the wording where you specify that the hypervisor may reject
that.
Peter
Attachments:
- signature.asc (application/pgp-signature — 884 bytes)