Re: [libvirt] [Xen-devel] [PATCH] libxl: initialize vfb defbools in libxlMakeVfb

On Wed, 2015-05-06 at 10:24 +0200, Olaf Hering wrote: > The code flow was essentially like this: > > libxl_device_vfb_init(libxl); > switch(libvirt->type) { > case SDL: > libxl_defbool_set(libxl->sdl.enable, 1); > break; > case VNC: > libxl_defbool_set(libxl->vnc.enable, 1); > break; > } > > if (libvirt->os.type == HVM) { > if (libxl_defbool_val(libxl->vnc.enable)) { > /* do VNC things */ > } else if (libxl_defbool_val(libxl->sdl.enable)) { > /* do SDL things */ > if (libxl_defbool_val(libxl->opengl.enable)) > /* do openGL things */ > } > } I see no code in libxl which matches what you have above, the only call to libxl_device_vfb_init has no switch statement or if == HVM anywhere near it.